Fix compiler flags to be compatible with ESP8622/Arduino #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 5, 2017 17:12
The .build.board=xx proptery is used for generating a macro named "ARDUINO_xxx". C macro names should never have a "-" sign. * current: ARDUINO_NodeMCU-32S * should be: ARDUINO_=NodeMCU_32S
see also "fix NodeMCU-32S .build.board property" #812 (#812 (comment)) `-DARDUINO_BOARD={build.board}` **is missing**
This reverts commit ea57b14.
|
Nice :) don't know how I missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also "fix NodeMCU-32S .build.board property" (#812 (comment))
-DARDUINO_BOARD={build.board}is missingWith this fix you get a macro
ARDUINO_BOARDwith the name of the selected board (e.g."NodeMCU-32S").https://github.com/esp8266/Arduino/blob/master/platform.txt#L75
https://github.com/esp8266/Arduino/blob/master/platform.txt#L78
https://github.com/esp8266/Arduino/blob/master/platform.txt#L81